Round-out provider-dashboard CI: lifecycle ci-test, governance, pos-instant#103
Merged
Conversation
The CI flow's `e2e/setup.sh` was updated to include the URL-scoped PP key, but the local `./test.sh e2e` runner uses a separate `test/setup-e2e.ts` writer that produces /config/contracts.env from the setup container. Without E2E_PP_PUBLIC_KEY in that file, the test-runner's loadConfig() throws before any bundle is submitted.
lifecycle/ci-test.ts is the test runner invoked by lifecycle's docker compose (and by provider-platform's lifecycle-reusable CI). Two fields were missed when lifecycle/main.ts was updated for the URL-scoped bundles work: - e2eConfig was missing ppPublicKey, so lib/client/bundle.ts composed /providers/undefined/bundles, which the resolver couldn't service. - Alice and Bob weren't registered as APPROVED entities before deposit/send, tripping the SUBMITTER_NOT_APPROVED gate. Mirrors the equivalent fixes already in lifecycle/main.ts.
provider-platform PR #103 (events dashboard redesign) renamed councilMembership (singular) → councilMemberships (plural array) on the dashboard /pp/list response. The governance e2e test was never updated to match. Now reads [0]?.status for the approved/rejected checks and .length === 0 for the no-council case.
Pay-platform submits bundles to provider-platform under its PAY_SERVICE_SK identity. provider-platform now gates bundle admission on the submitter being an APPROVED entity (SUBMITTER_NOT_APPROVED), so the pay-service keypair needs an entity record before the instant payment flow can run. New [1b/5] step calls POST /api/v1/entities with keys.payService right after funding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #101 — fixes the harnesses that were missed because they live next to (but aren't) the runners that the first PR touched:
lifecycle/ci-test.tsis what the lifecycle Docker compose actually invokes (lifecycle/main.tsis local-only). Now wiresppPublicKeyon Config and registers Alice/Bob via /api/v1/entities before deposit/send. This is what unblocks provider-platform's lifecycle CI.e2e/governance/uc2-approve-reject.tsstill read.councilMembership(singular) on the dashboard /pp/list response; provider-platform PR Round-out provider-dashboard CI: lifecycle ci-test, governance, pos-instant #103 had renamed it to.councilMemberships(plural array) months ago. Updated reads to[0]?.status/.length === 0.e2e/pos-instant/main.tsregisterskeys.payServiceas APPROVED before the instant payment flow, since pay-platform authenticates to provider-platform under that key and otherwise trips the SUBMITTER_NOT_APPROVED gate.test/setup-e2e.tswritesE2E_PP_PUBLIC_KEYto /config/contracts.env. (e2e/setup.shalready had this in the CI flow; the local./test.sh e2eflow uses the test/ setup script and needs the same line.)Test plan
Locally (
./test.sh all), all 5 suites green: e2e, otel, governance, lifecycle, pos-instant.After this merges, re-running provider-platform's PR CI (Moonlight-Protocol/provider-platform#106) should flip lifecycle from red to green.