Skip to content

feat: Debugger networking/packet improvements to use Cereal#360

Open
AlexDenfordSkyboxLabs wants to merge 17 commits into
mainfrom
sbl/alex.denford/debugger-investigation
Open

feat: Debugger networking/packet improvements to use Cereal#360
AlexDenfordSkyboxLabs wants to merge 17 commits into
mainfrom
sbl/alex.denford/debugger-investigation

Conversation

@AlexDenfordSkyboxLabs
Copy link
Copy Markdown
Contributor

@AlexDenfordSkyboxLabs AlexDenfordSkyboxLabs commented Mar 27, 2026

This is a matching/supplement PR for the networking packet changes in MC for using Cereal.
Key changes

  • Added 'handlers' instead of use if X for all the event types
  • Moved the packet definitions/types to a separate file
  • Documented the protocol version properly
  • Updated contributing doc with some extra notes

@AlexDenfordSkyboxLabs AlexDenfordSkyboxLabs changed the title [Task AB#1553866]: Adding support for C++ driven data source schema descriptors feat: Adding support for C++ driven data source schema descriptors Mar 27, 2026
@JakeShirley
Copy link
Copy Markdown
Member

whoops, sorry I closed this on accident.

@JakeShirley JakeShirley reopened this May 27, 2026
@AlexDenfordSkyboxLabs AlexDenfordSkyboxLabs changed the title feat: Adding support for C++ driven data source schema descriptors feat: Debugger networking/packet improvements to use Cereal May 27, 2026
Copy link
Copy Markdown
Contributor

@SBLMikeDemone SBLMikeDemone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes due to the package-lock changes, otherwise this looks good! It's a separation I'm very happy with

Comment thread src/protocol-events.ts Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread package-lock.json
Comment thread src/session.ts
Comment thread src/protocol-events.ts Outdated
Comment thread src/protocol-events.ts Outdated
Comment thread src/stats/stats-provider.ts Outdated
Comment thread webview-ui/package-lock.json
Copy link
Copy Markdown
Contributor

@SBLMikeDemone SBLMikeDemone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants