Fix recommendation request failures and clean up landing page#6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/recommendcould be blocked by restrictive CORS settings, producing a generic "Something went wrong" UI state that offered no diagnostic information.Description
backend/app/main.pyand bumped the API version to0.2.1so common dev hostnames and Codespaces-hosted pages are permitted by CORS.error-detailelement tofrontend/index.htmland wired it into the UI so request errors can surface detailed messages.frontend/main.jsby readingresponse.text()on non-OK responses and passingRequest failed (<status>): <body>intoshowStateso the error panel displays actionable details.frontend/index.htmlandfrontend/styles.css(new hero highlights, updated spacing, colors, focus states, and card polish) for a cleaner presentation.Testing
python -m py_compile backend/app/main.py backend/app/api/recommend.py backend/app/models/schemas.py backend/app/scoring/engine.py, which completed successfully.node --check frontend/main.js, which completed successfully.PYTHONPATH=backend python - <<'PY' ... recommend(UserPreferences.model_validate(payload)) ... PY, which returned recommendations and a valid meta summary, indicating the scoring and response flow works as expected.Codex Task