Skip to content

Fix frontend loading state remaining visible after successful recommendations#5

Merged
MohammedAlkindi merged 1 commit into
mainfrom
codex/diagnose-and-fix-frontend-recommendation-issue
Apr 2, 2026
Merged

Fix frontend loading state remaining visible after successful recommendations#5
MohammedAlkindi merged 1 commit into
mainfrom
codex/diagnose-and-fix-frontend-recommendation-issue

Conversation

@MohammedAlkindi

Copy link
Copy Markdown
Owner

Motivation

  • The UI stayed on the "Curating recommendations…" loading card because the frontend set loading on submit but never cleared it when the API call succeeded.

Description

  • Clear the loading state in submitPayload() by calling showState({}) after a successful fetchRecommendations() so the results (or empty/error state) can render; change made only to frontend/main.js with commit message Fix frontend loading state after successful recommendations.

Testing

  • Ran node --check frontend/main.js which passed; called backend health() via PYTHONPATH=. python -c "from app.main import health; print(health())" which returned {'status': 'ok'}; invoked the recommendation flow via app.api.recommend.recommend with a normal payload and observed 8 recommendations and a valid meta.summary, confirming the end-to-end contract and that the frontend will now exit loading and render results.

Codex Task

@MohammedAlkindi
MohammedAlkindi merged commit 6260f76 into main Apr 2, 2026
1 check passed
@MohammedAlkindi
MohammedAlkindi deleted the codex/diagnose-and-fix-frontend-recommendation-issue branch April 2, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant