Fix frontend loading state remaining visible after successful recommendations#5
Merged
MohammedAlkindi merged 1 commit intoApr 2, 2026
Conversation
MohammedAlkindi
deleted the
codex/diagnose-and-fix-frontend-recommendation-issue
branch
April 2, 2026 16:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
loadingon submit but never cleared it when the API call succeeded.Description
submitPayload()by callingshowState({})after a successfulfetchRecommendations()so the results (or empty/error state) can render; change made only tofrontend/main.jswith commit messageFix frontend loading state after successful recommendations.Testing
node --check frontend/main.jswhich passed; called backendhealth()viaPYTHONPATH=. python -c "from app.main import health; print(health())"which returned{'status': 'ok'}; invoked the recommendation flow viaapp.api.recommend.recommendwith a normal payload and observed 8 recommendations and a validmeta.summary, confirming the end-to-end contract and that the frontend will now exit loading and render results.Codex Task