add esp32/m5nanoh2 - #1676
Open
stc1988 wants to merge 2 commits into
Open
Conversation
Collaborator
|
Thanks for the PR. It generally looks fine. There is one change that is unusual, the modification of esp32/manifest.json. This is the only time an M5 device has been added to this file. I acknowledge that the use of the esp32/manifest.json is a bit inconsistent. If possible it would be best to keep support for individual boards in their own manifest rather than the overarching ESP-IDF manifest. Would you see if that is possible here? Thank you. |
Contributor
Author
|
I modified esp32/manifest.json because a build error occurred when including io/manifest.json on this board. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I revised the setup implementation for the M5NanoC6 to match the M5NanoH2.