Advance the MEOS commit and follow it in the pose header and the expected answers - #359
Merged
estebanzimanyi merged 3 commits intoSep 2, 2026
Conversation
MobilityDB ships the pose chains with the poses: meos_pose.h declares posechain_in, posechain_out and the rest of the chain surface, and there is no meos_posechain.h to include. Both sites reaching for it already include meos_pose.h on the line above, so the declarations arrive either way and the two includes name a file the install prefix does not carry. Without this a build against any MEOS carrying the pose chains stops at meos_wrapper_simple.hpp with "meos_posechain.h: No such file or directory", which is every translation unit that reaches the generated surface.
An MF-JSON datetime carries the RFC 3339 offset, so a tpcpoint at 2024-01-01 reads "+01:00" where the suite states "+01", and a temporal value answers the hash of the function of time, which moves each of the four hash and hashExtended values the suite states by the same amount. Both are what MobilityDB answers at the commit this port builds against, from "Write an MF-JSON datetime as RFC 3339" and "Answer equality, the B-tree order and the hash from the function of time"; the suite states the values of the commit it built against before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MEOS commit the port builds carries the pose chains with the poses, so
meos_pose.h declares the chain surface and no meos_posechain.h is installed:
the two sites including it read the declarations from the pose header, which
they already include on the line above.
At that commit an MF-JSON datetime also carries the RFC 3339 offset and a
temporal value answers the hash of the function of time, so the suite states
"+01:00" for a tpcpoint at 2024-01-01 and the four hash and hashExtended
values MEOS now answers.
Carries the pin advance and the regenerated surface of #357, which builds
only with the three together.