Hold the generated types package to the same regeneration as functions - #27
Merged
estebanzimanyi merged 1 commit intoSep 3, 2026
Conversation
CI builds the committed functions/ snapshot, regenerates it from a freshly derived catalog and reports the drift; types/ arrives generated and no step regenerates it, so nothing would notice it drifting away from the catalog it is supposed to be a projection of. A generated tree nothing regenerates is a hand-written tree with a comment on top. `objectgen.py` RUNS `codegen.py` and then projects the object model, so one command regenerates both and neither can be refreshed without the other -- which matters because types/ calls the wrappers codegen emits, and a functions/ refreshed alone leaves the object layer calling a surface that has moved. The CI regeneration step and the refresh recipe both invoke it; its catalog argument now defaults to tools/meos-idl.json, where the refresh stages one, so the command reads the same in both places. The committed-snapshot build and the drift report widen to cover both packages. That build is the step that FAILS, and it is where a consumer breakage is caught: a snapshot which no longer compiles is invisible to a job that regenerates first. MEASURED on the catalog this tree was generated from: regeneration reproduces the committed functions/ and types/ with 0 files differing against 116 tracked type files, so the committed tree IS the projection rather than a snapshot of one. `go build ./functions ./types`, `go build ./...` over all 12 packages, `go vet ./types` and the parity gate all exit 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI builds the committed functions/ snapshot, regenerates it from a freshly
derived catalog and reports the drift; types/ arrives generated and no step
regenerates it, so nothing would notice it drifting away from the catalog it is
supposed to be a projection of. A generated tree nothing regenerates is a
hand-written tree with a comment on top.
objectgen.pyRUNScodegen.pyand then projects the object model, so onecommand regenerates both and neither can be refreshed without the other -- which
matters because types/ calls the wrappers codegen emits, and a functions/
refreshed alone leaves the object layer calling a surface that has moved. The CI
regeneration step and the refresh recipe both invoke it; its catalog argument now
defaults to tools/meos-idl.json, where the refresh stages one, so the command
reads the same in both places.
The committed-snapshot build and the drift report widen to cover both packages.
That build is the step that FAILS, and it is where a consumer breakage is caught:
a snapshot which no longer compiles is invisible to a job that regenerates first.
MEASURED on the catalog this tree was generated from: regeneration reproduces the
committed functions/ and types/ with 0 files differing against 116 tracked type
files, so the committed tree IS the projection rather than a snapshot of one.
go build ./functions ./types,go build ./...over all 12 packages,go vet ./typesand the parity gate all exit 0.