Improve Knip configuration and cleanup unused exports#26
Conversation
- Add `tests/**/*.ts` to `knip.json` project scope to correctly detect test dependency usage. - Declare `lib/sdk/orchestrator.ts` as an `entry` point instead of ignoring it. - Remove `export` from internal variables and functions in `lib/common.ts`, `lib/memory.ts`, and `lib/team.ts`. - Delete `tsconfig.tsbuildinfo` build artifact. - Update `bun.lock` after dependency verification. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
I improved the Knip configuration to reduce the number of ignores and ensure better dependency tracking. Key changes include:
tests/directory in Knip's analysis, which allows it to see thatvitestandbatsare indeed used.lib/sdk/orchestrator.tsas an entry point, as it is a public SDK component.exportkeywords from several functions and constants that were only used internally.tsconfig.tsbuildinfoartifact which should not be in the repository.The final configuration is much cleaner and relies on fewer broad ignores.
PR created automatically by Jules for task 16981579624355540868 started by @Mitriyweb