Fix unbounded RefreshOpenState recursion when player controls are already disabled - #110
Fix unbounded RefreshOpenState recursion when player controls are already disabled#110Drheisen1 wants to merge 3 commits into
Conversation
Search DRHEISEN1
882a0bb to
9c14198
Compare
|
Thanks for the submission! I believe this particular stack overflow should be fixed by 18e7759, which I hadn't gotten around to pushing yet. |
|
|
||
| #pragma warning(pop) | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Please keep the newline at the end
|
sorry, it's my first time doing pull requests :3 |
|
All good, thanks for taking the time to contribute. If possible, amend your commit and force push the changes. I like to keep a clean history. Let me know if you need help doing that. Alternatively I could do it myself, but then your name wouldn't show in the commit history. |
Co-authored-by: AtomCrafty <atomcrafty@frucost.net>
|
sorry, im kinda lost here :p , can you do it? I don't mind the naming |
|
Sure thing, I'll take care of it later :) |
2 participants
added re-entry guard, only changed lines 231-241 in MenuVisibilityManager. Search "DRHEISEN1"
why:
https://mega.nz/file/iwsm1KoD#de9EQDfVXA91kW64cxsm31454P3RXSj_wy2vunhx3E8
https://mega.nz/file/mt8ynC7Z#FHz18ERY04i3nC4b1VqsC71st9LAZ5ZPayu8cgFAxa8
https://mega.nz/file/34EjUKRD#GgiVQBoLuxrAkkUXWZ8rlYkuSdYoQaW8KegnAEZrGlU