fix: upsert VA file manifest instead of delete+reinsert - #7
Merged
Conversation
Re-importing a known export file deleted and re-inserted the same manifest key in one transaction, which DuckDB's ART unique index rejects. Upsert via ON CONFLICT and, on --rebuild-va, prune only vanished paths.
One transaction inserting millions of enrichment rows buffers ART index maintenance until COMMIT and OOMs a 4GB host. Stage the parquet joins in temp tables, then delete and insert against the indexed tables in 250k-row transactions, recording the manifest last so an interrupted import re-runs in full.
ozwaldorf
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-importing a known export file deleted and re-inserted the same manifest key in one transaction, which DuckDB's ART unique index rejects. Upsert via ON CONFLICT and, on --rebuild-va, prune only vanished paths.