Ber implementation for receiver - #64
Open
aamirq wants to merge 14 commits into
Open
Conversation
…e receiver() function.
* add preamp and boost to roadm; fix simulation tests * reverse enabling boost in link * fixing link * add emulation test with ROADM w/amps; enable Transceiver as param in Terminal constructor * add preamp and boost to ROADM; fix simulation tests; add emulation test with ROADM w/amps; enable Transceiver as param in Terminal constructor * change permissions * minor edit * minor edit * add preamp and boost to ROADM; fix simulation tests; add emulation test with ROADM w/amps; enable Transceiver as param in Terminal constructor
decomposed propagation algorithm @link, moved Link phy-models to Span class and cleaned code
# Conflicts: # node.py
lantz
requested changes
May 29, 2021
lantz
left a comment
lantz
left a comment
Collaborator
There was a problem hiding this comment.
- What is the reason for deleting a line in singlelink.py?
- Is there a reason to include the files in ofcdemo? Are they used as tests or something?
- Could you flatten the commits into a single commit?
Collaborator
Author
|
shoot. I think I fucked up on my rebase commands...
…On Fri, May 28, 2021 at 5:31 PM lantz ***@***.***> wrote:
***@***.**** requested changes on this pull request.
1. What is the reason for deleting a line in singlelink.py?
2. Is there a reason to include the files in ofcdemo? Are they used as
tests or something?
3. Could you flatten the commits into a single commit?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#64 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADAQIZS2W7ITDKBMXTG7JPLTQAYVDANCNFSM45XVFBGA>
.
|
Collaborator
|
@aamirq I sit possible to resolve the conflicts? And also to flatten the commits? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey I was able to implement code for the bit error rate. can you check the code and commit it in,