Add node.Splitter() - #147
Open
lantz wants to merge 1 commit into
Open
Conversation
Splitter() is a simple splitter element that currently does not model coupling loss (although the split percents may be adjusted to model it as desired.) Note that Splitter() copies the signal to the split port if needed, creating a new signal that originates at the splitter. We do this in case this signal needs to propagate through one of the elements that the original signal propagates through. - add tests/splittertest.py - also remove dodgy intermediate signal state storage in OpticalSignal - also make assoc_loc_in/out more reliable by requiring at least one parameter - also remove unused include_optical_signal_in_roadm and references to it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitter() is a simple splitter element that currently does not model coupling loss (although the split percents may be adjusted to model it as desired.)
Note that Splitter() copies the signal to the split port if needed, creating a new signal that originates at the splitter. We do this in case this signal
needs to propagate through one of the elements that the original signal propagates through.
add tests/splittertest.py
also remove dodgy intermediate signal state storage in OpticalSignal
also make assoc_loc_in/out more reliable by requiring at least one parameter
also remove unused include_optical_signal_in_roadm and references to it