Fix MCP OAuth Connect permission gating - #246
Open
NianJiuZst wants to merge 1 commit into
Open
Conversation
NianJiuZst
marked this pull request as ready for review
August 11, 2026 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canConnectpermission from the workspace owner/admin roleRoot cause and impact
The MCP directory UI distinguished import permission, which includes members, but did not model the narrower OAuth connection permission. Every disconnected OAuth connector therefore rendered an active Connect action even though the backend OAuth start and callback routes authorize only workspace owners and admins. Members and viewers could open a popup that was guaranteed to receive a 403 and never complete the parent-page flow.
The UI now uses the same owner/admin boundary as the backend. Members can still import an OAuth connector after an administrator has connected it, while unauthorized users no longer receive a misleading active Connect action.
Validation
pnpm exec playwright test --config tests/e2e/playwright.config.ts tests/e2e/mcp-directory.spec.ts --grep "MCP OAuth"(3 passed)pnpm --filter @parsar/web typecheckgo test ./server/internal/api/mcpdirectory -run '^TestOAuthConnectRequiresWorkspaceAdmin$' -count=1make checkmake checkpassed. Docker was unavailable locally, so the PostgreSQL migration smoke test was skipped; this change does not touch database code or migrations.The full
mcp-directory.spec.tsstill hits an unrelated pre-existing Skill-tab mock failure at theDiagram Makerassertion. The same failure was reproduced on the unmodifiedmainbaseline at90146d4; all OAuth-focused cases pass.