Add request timeout to crawler _make_request to prevent hangs - #52
Open
bunlongheng wants to merge 1 commit into
Open
Add request timeout to crawler _make_request to prevent hangs#52bunlongheng wants to merge 1 commit into
bunlongheng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crawler's _make_request calls urllib.request.urlopen without a timeout, so a slow or dead host (very common when crawling over Tor) blocks the whole crawl forever with no way to recover. I added timeout=10 to both urlopen calls, which matches what extractor.py already does for its own requests. Small change, it just makes the crawler fail fast instead of hanging on a bad host.