fixup: unset driverNames reference before building vendor columns#376
Merged
MightyCreak merged 1 commit intoJul 3, 2026
Merged
Conversation
Owner
|
I remember deleting this line because I couldn't see what was its purpose... and I still don't see it. I don't understand why the second foreach doesn't override this variable... |
Owner
|
Oh... I see. driverNames is a reference, and the next foreach doesn't reassign the variable, it reassigns the ref 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of MesaMatrix has a bug in the column generation code that affects all generated tables on the site. I noticed this when trying to look for new KosmicKrisp features, which had been overwritten with a second lavapipe column.
The createColumns() loop left $driverNames as a reference to the last vendor, causing the second foreach to overwrite anything in the last column with the previous data.
This is a one line change that I've confirmed locally to fix the issue. Please let me know if you have any questions.