Remove cert-manager issuer annotations from ALB config#128583
Conversation
Removed cert-manager issuer annotations for ALB resources.
Removed the configuration option to enable Gateway API during cert-manager installation.
|
@jkerken : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
1 similar comment
|
@jkerken : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit ab6adf5: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
Bot
added
the
aq-pr-triaged
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the Gateway API + Azure ALB documentation to remove cert-manager issuer annotations and a cert-manager Helm flag, aiming to reflect a manual certificate creation/rotation flow.
Changes:
- Removed
cert-manager.io/issuerannotations from ALB/Gateway manifests. - Removed
--set config.enableGatewayAPI=truefrom the cert-manager Helm install example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| annotations: | ||
| alb.networking.azure.io/alb-namespace: alb-test-infra | ||
| alb.networking.azure.io/alb-name: alb-test | ||
| cert-manager.io/issuer: letsencrypt-prod | ||
| spec: | ||
| gatewayClassName: azure-alb-external | ||
| listeners: |
| --version v1.19.3 \ | ||
| --namespace cert-manager \ | ||
| --create-namespace \ | ||
| --set config.enableGatewayAPI=true \ | ||
| --set crds.enabled=true |
| namespace: test-infra | ||
| annotations: | ||
| alb.networking.azure.io/alb-id: $RESOURCE_ID | ||
| cert-manager.io/issuer: letsencrypt-prod | ||
| spec: | ||
| gatewayClassName: azure-alb-external | ||
| listeners: |
|
#assign-reviewer: @JackStromberg |
Removed cert-manager issuer annotations for ALB resources since they only work when used with with a hostname in the listener see: https://cert-manager.io/docs/usage/gateway/
The follwoing flag is also not needed in this case : "-set config.enableGatewayAPI=true" since the certificate is manualy created
This is article is confusing manual certi creation with the automatic version. I have changed it so it is only having the required settings for manual cert rotation