Skip to content

chore(deps): bump jsonc-parser from 0.32.4 to 0.33.0 - #136

Merged
Microck merged 1 commit into
mainfrom
dependabot/cargo/jsonc-parser-0.33.0
Jul 25, 2026
Merged

chore(deps): bump jsonc-parser from 0.32.4 to 0.33.0#136
Microck merged 1 commit into
mainfrom
dependabot/cargo/jsonc-parser-0.33.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 13, 2026

Copy link
Copy Markdown
Contributor

Bumps jsonc-parser from 0.32.4 to 0.33.0.

Commits
  • 20d89e2 0.33.0
  • 2f3a463 feat(BREAKING): add new wrapped Map type (#83)
  • 2f578b2 perf: optional fast_hash feature for a faster (non-DoS-resistant) hasher (#82)
  • 6923687 perf(serde): borrow object keys during deserialization to avoid per-key alloc...
  • ab679c0 perf(BREAKING): parse_to_value - borrow object keys with Cow\<'a, str> to ...
  • See full diff in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Jul 13, 2026
@dependabot
dependabot Bot requested a review from Microck as a code owner July 13, 2026 07:44
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Jul 13, 2026
@dependabot
dependabot Bot force-pushed the dependabot/cargo/jsonc-parser-0.33.0 branch from bbc74a9 to 44b9857 Compare July 19, 2026 23:38
@greptile-apps

greptile-apps Bot commented Jul 19, 2026

Copy link
Copy Markdown

PR author is in the excluded authors list.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@dependabot
dependabot Bot force-pushed the dependabot/cargo/jsonc-parser-0.33.0 branch from 44b9857 to 4953dc5 Compare July 25, 2026 21:02
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The jsonc-parser dependency in Cargo.toml is updated from 0.32.4 to 0.33.0, with the existing serde feature retained.

Changes

Dependency update

Layer / File(s) Summary
Update jsonc-parser version
Cargo.toml
Updates jsonc-parser to version 0.33.0 while retaining the serde feature.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: microck

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Release Metadata Consistency ⚠️ Warning Cargo.toml and Cargo.lock are 0.14.3, but npm/package.json is 0.14.2; CHANGELOG.md does include ## [0.14.3]. Bump npm/package.json to 0.14.3 (or align all three files to the same release version) and keep the matching CHANGELOG heading.
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the single change: bumping jsonc-parser from 0.32.4 to 0.33.0.
Description check ✅ Passed It clearly describes the dependency bump and adds release context, which is sufficient even though the template sections are omitted.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependabot/cargo/jsonc-parser-0.33.0

Comment @coderabbitai help to get the list of available commands.

@dependabot
dependabot Bot force-pushed the dependabot/cargo/jsonc-parser-0.33.0 branch 2 times, most recently from 2a66446 to 3e4aeb2 Compare July 25, 2026 21:07

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Cargo.toml (1)

33-33: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add regression coverage for the JSONC serde path.

src/mcp_install.rs still relies on parse_to_serde_value::<serde_json::Value> with the serde feature, which remains the documented API in jsonc-parser 0.33.0. (docs.rs) Because this release includes breaking changes, test commented JSONC input and rejection of non-object roots before merging.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Cargo.toml` at line 33, Add regression tests for the JSONC serde parsing path
used by parse_to_serde_value in src/mcp_install.rs: verify commented JSONC input
parses successfully and non-object root values are rejected. Keep the
jsonc-parser 0.33.0 serde feature and cover both behaviors through the existing
MCP installation parsing flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Cargo.toml`:
- Line 33: Add regression tests for the JSONC serde parsing path used by
parse_to_serde_value in src/mcp_install.rs: verify commented JSONC input parses
successfully and non-object root values are rejected. Keep the jsonc-parser
0.33.0 serde feature and cover both behaviors through the existing MCP
installation parsing flow.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ee1a829-96d3-450e-adab-322f4b29b291

📥 Commits

Reviewing files that changed from the base of the PR and between 4953dc5 and 2a66446.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

@dependabot
dependabot Bot force-pushed the dependabot/cargo/jsonc-parser-0.33.0 branch 3 times, most recently from 1f55fea to 79609a2 Compare July 25, 2026 21:22
@Microck

Microck commented Jul 25, 2026

Copy link
Copy Markdown
Owner

@dependabot rebase

Bumps [jsonc-parser](https://github.com/dprint/jsonc-parser) from 0.32.4 to 0.33.0.
- [Commits](dprint/jsonc-parser@0.32.4...0.33.0)

---
updated-dependencies:
- dependency-name: jsonc-parser
  dependency-version: 0.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/cargo/jsonc-parser-0.33.0 branch from 79609a2 to f8ea5d7 Compare July 25, 2026 21:23
@Microck
Microck merged commit 4305f8e into main Jul 25, 2026
6 checks passed
@Microck
Microck deleted the dependabot/cargo/jsonc-parser-0.33.0 branch July 25, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant