fix: move esbuild to dependencies so pi install can run the prepare script - #6
Open
matthewryanscott wants to merge 1 commit into
Open
fix: move esbuild to dependencies so pi install can run the prepare script#6matthewryanscott wants to merge 1 commit into
matthewryanscott wants to merge 1 commit into
Conversation
esbuild is required at install time by the prepare script (npm run build:runtime). Since pi install runs npm install --omit=dev, devDependencies are not available, causing the build to fail. Moving esbuild to dependencies ensures it's present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing via
pi install, the command runsnpm install --omit=dev, which skips devDependencies. Thepreparelifecycle script invokesnpm run build:runtime, which callsbuild.mjs— and that script importsesbuild.Since
esbuildis only indevDependencies, it's not available duringpi install, causing the build to fail:This moves
esbuildfromdevDependencies→dependenciesso it's available at install time when pi runsnpm install --omit=dev.I'm offering this as the fix that worked for me, but totally understand if there's a better approach—happy for this to be rejected in favor of a cleaner solution.
(LLM-assisted PR)