Support generic leaderboard views - #2
Open
KyleHerndon wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the commissioners-side generic leaderboard redesign from the archived commissioners repo into coworld-tools.
Summary:
round_results_request/round_results_responseplusRoundPlatformClient.get_round_results(...)so commissioners can fetch historical rows for EWMA or other time-window calculations.Validation:
uv run pytest tests/test_commissioner_strategies.py -q: 75 passeduv run python -m compileall commissioners tests/test_commissioner_strategies.py -q: passeduv run pytest tests/test_commissioner_websocket.py::test_round_platform_client_requests_round_results tests/test_commissioner_websocket.py::test_protocol_accepts_prefixed_round_public_id_and_episode_completed_response -q: 2 passeduv run python -m py_compile commissioners/common/protocol.py commissioners/common/server.py tests/test_commissioner_websocket.py: passeduv run ruff check commissioners/common/protocol.py commissioners/common/server.py tests/test_commissioner_websocket.py: unavailable, ruff is not installed in this repo envuv run pyright commissioners tests/test_commissioner_strategies.py: unavailable, pyright is not installed in this repo envtimeout 90s uv run pytest tests/test_commissioner_websocket.py -q: timed out before producing output; the focused protocol/client tests above cover this change