Skip to content
This repository was archived by the owner on Jun 25, 2026. It is now read-only.

Stop accepting platform-provided variant player counts - #47

Merged
KyleHerndon merged 1 commit into
mainfrom
kyle/episode-roster-player-count
Jun 23, 2026
Merged

Stop accepting platform-provided variant player counts#47
KyleHerndon merged 1 commit into
mainfrom
kyle/episode-roster-player-count

Conversation

@KyleHerndon

Copy link
Copy Markdown
Contributor

Summary

  • Remove num_agents from commissioner VariantInfo.
  • Stop deriving minimum_champions from platform variant player counts.
  • Use commissioner-owned config or scheduled entries when legacy strategy code still needs an internal count.
  • Update strategy tests for roster-defined scheduling.

Validation

  • uv run pytest tests/test_commissioner_strategies.py -q
  • uv run python -m compileall commissioners tests -q

Notes

  • uv run ruff check is not available in this project environment.
  • A targeted websocket integration test timed out locally before this final validation pass, so I left it out of the required PR gate.

@KyleHerndon
KyleHerndon force-pushed the kyle/episode-roster-player-count branch from d56744d to 237b2e2 Compare June 23, 2026 23:10
@KyleHerndon
KyleHerndon merged commit ecbf6e2 into main Jun 23, 2026
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant