Skip to content

Reverse and Direct models of NPP Metroscopia - #604

Open
Rawan-met wants to merge 8 commits into
mainfrom
NPPMetroscopia_corrected
Open

Reverse and Direct models of NPP Metroscopia#604
Rawan-met wants to merge 8 commits into
mainfrom
NPPMetroscopia_corrected

Conversation

@Rawan-met

Copy link
Copy Markdown

Goal

The goal is to fix NPP Metroscopia reverse model and create its direct model using MML v4.0.0-beta2.

I noticed that the initial component values in the direct NPP model in the examples folder differed significantly from those in the reverse model. This may explain the discrepancies we observed in the calibrated parameter values, so I aligned them.

I also added the missing superheater_Kth parameter and corrected the name of the slide valve’s actual output, which had been mislabeled.

Finally, I swapped rh and hn for the extraction sensors: the extraction pressure sensor should use hn, while the extraction temperature sensor should use rh. These were incorrectly defined in the library.

I verified the initial values in the reverse model, retrieved the calibrated parameter values, applied them to the direct model, and ran it successfully. Everything is now working as expected with the corrections in place.

Type of change

  • [ X] Bugfix
  • New feature
  • Refactoring change
  • [X ] Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

  • Breaking change (If yes, make sure to point it out in the changelog)
  • [X ] Non-Breaking change

Checklist

  • [ X] I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
  • [ X] I have performed a self-review of my own code
  • I have checked that all existing tests pass
  • I have checked that my work is compatible with OpenModelica
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation (in Notion documentation)
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

@Rawan-met Rawan-met self-assigned this Aug 6, 2026
@Rawan-met Rawan-met added 🐛bug Something isn't working 👨‍💻 Example Modified or added examples 4️⃣MML4 labels Aug 6, 2026
@LucileD-met

Copy link
Copy Markdown
Contributor

there is an issue with this PR : you probably copy-pasted the models in the folder instead of moving them into the package (and replacing the old MteroscopiaNPP models)

A better way to do it

  • you should modify directly the models of the library in dymola then commit so that I can see in github what lines defer from the previous version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 4️⃣MML4 👨‍💻 Example Modified or added examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants