Reverse and Direct models of NPP Metroscopia - #604
Open
Rawan-met wants to merge 8 commits into
Open
Conversation
Contributor
|
there is an issue with this PR : you probably copy-pasted the models in the folder instead of moving them into the package (and replacing the old MteroscopiaNPP models) A better way to do it
|
This reverts commit 3cce248.
LucileD-met
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal is to fix NPP Metroscopia reverse model and create its direct model using MML v4.0.0-beta2.
I noticed that the initial component values in the direct NPP model in the examples folder differed significantly from those in the reverse model. This may explain the discrepancies we observed in the calibrated parameter values, so I aligned them.
I also added the missing superheater_Kth parameter and corrected the name of the slide valve’s actual output, which had been mislabeled.
Finally, I swapped rh and hn for the extraction sensors: the extraction pressure sensor should use hn, while the extraction temperature sensor should use rh. These were incorrectly defined in the library.
I verified the initial values in the reverse model, retrieved the calibrated parameter values, applied them to the direct model, and ran it successfully. Everything is now working as expected with the corrections in place.
Type of change
package.mo)Will it break anything in previous models ?
Checklist