update to steam dryer model using efficiency as input - #602
Open
benr-met wants to merge 4 commits into
Open
Conversation
Previouslly steam dryer inlet enthalpy defined as C_in.h_outflow which is 1e6 by default. Replaced it with steam_phase.h_in which is the same as liquid_phase.h_in and varies appropriately with the boundary conditions.
Clarified in comments that you can still define the outlet steam fraction rather than the MS efficiency, provided you set inpt_specs = true
Updated the CHANGELOG to reflect changes in steam dryer input defaults and how to maintain compatibility with existing models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Describe the big picture of your changes here (one sentence).
Update steam dryer component so that efficeincy is input instead of outlet vapor fraction, with the option to input steam fraction manually and option to model a steam fraction efficiency decrease fault. New steam dryer healty and fault test included. Response to the following issue:
#594
If you wish to incorporate into existing models and not change results at all, then set input_specs = true and define the outlet steam fraction as 0.99
Type of change
package.mo)Will it break anything in previous models ?
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.