Skip to content

copy edit: simplify new comments email intro#5036

Merged
aseckin merged 5 commits into
mainfrom
claude/issue-3184-copy-edit-to-transactional-email
Jul 17, 2026
Merged

copy edit: simplify new comments email intro#5036
aseckin merged 5 commits into
mainfrom
claude/issue-3184-copy-edit-to-transactional-email

Conversation

@aseckin

@aseckin aseckin commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Simplifies the intro line in the new comments transactional email so it no longer awkwardly renders "these 1 questions" in the singular case.

Changes:

  • Update intro text from "There are new comments on these {{ count }} questions:" to "There are new comments on"
  • Applied to both the .mjml source and the compiled .html template

Closes #3184

Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Updated new-comment email notifications with clearer introductory wording.
    • Removed potentially confusing notification counts and question-specific phrasing from the email header.

Closes #3184

Co-authored-by: aseckin <3686968+aseckin@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The new-comment HTML and MJML email templates replace count-based, question-specific introductory text with the translated phrase “There are new comments on”.

Changes

New-comment email copy

Layer / File(s) Summary
Update new-comment email headers
notifications/templates/emails/post_new_comments.html, notifications/templates/emails/post_new_comments.mjml
Both templates use a direct translation for “There are new comments on” and remove notification-count interpolation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A bunny nudged the email line,
No counts or questions in the design.
“New comments on” now hops in place,
With simpler words and cleaner grace.
Squeak!

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: simplifying the new comments email intro.
Linked Issues check ✅ Passed The PR addresses #3184 by removing the awkward count-based plural wording from the new comments email copy.
Out of Scope Changes check ✅ Passed The changes are limited to the email intro copy in the two template files and stay within the stated objective.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-3184-copy-edit-to-transactional-email

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Cleanup: Preview Environment Removed

The preview environment for this PR has been destroyed.

Resource Status
🌐 Preview App Deleted
🗄️ PostgreSQL Branch Deleted
⚡ Redis Database Deleted
🔧 GitHub Deployments Removed
📦 Docker Image Retained (auto-cleanup via GHCR policies)

Cleanup triggered by PR close at 2026-07-17T13:48:16Z

@aseckin
aseckin marked this pull request as ready for review July 16, 2026 12:34
@aseckin
aseckin requested a review from ncarazon July 16, 2026 12:34

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@notifications/templates/emails/post_new_comments.mjml`:
- Line 14: The translated intro in
notifications/templates/emails/post_new_comments.mjml lines 14-14 should end
with a colon: update it to “There are new comments on:”. Synchronize
notifications/templates/emails/post_new_comments.html lines 177-177 with the
same compiled text.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d3b9a114-b514-469e-b08d-bb9fa372ad98

📥 Commits

Reviewing files that changed from the base of the PR and between b506092 and cb98e35.

📒 Files selected for processing (2)
  • notifications/templates/emails/post_new_comments.html
  • notifications/templates/emails/post_new_comments.mjml

Comment thread notifications/templates/emails/post_new_comments.mjml
@aseckin
aseckin merged commit f9a3879 into main Jul 17, 2026
15 checks passed
@aseckin
aseckin deleted the claude/issue-3184-copy-edit-to-transactional-email branch July 17, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copy edit to transactional email

2 participants