Fix coverage crash on cost reports in reports/#311
Merged
Conversation
Since #299, write_cost_report puts <run_id>_cost.json (a JSON dict) next to the run reports. read_outcomes assumed every .json under reports/ was a list of outcome rows, so iterating the dict's string keys raised AttributeError — breaking coverage for any archive with a cost report. Skip *_cost.json keys and, defensively, any blob whose JSON is not a list. Works for both the flat layout and the nested layout coming in Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cost reporting bug for URL archival.
read_outcomesparsed every.jsonunderreports/as a list of outcome rows, but<run_id>_cost.jsonfiles (added in #299) are dicts — sosource-archive coveragecrashed with an AttributeError on any archive containing a cost report. Now skips_cost.jsonkeys and any non-list JSON, for both the flat and nested layouts. Includes a regression test.