feat: integrate feature extraction into perform - #44
Closed
ucodia wants to merge 9 commits into
Closed
Conversation
ucodia
force-pushed
the
feat/feature-extraction-redesign
branch
from
July 24, 2026 08:04
5b908a5 to
af1b4e8
Compare
ucodia
force-pushed
the
feat/feature-extraction-redesign
branch
from
August 2, 2026 05:15
2275789 to
fb344b4
Compare
8 tasks
Collaborator
Author
|
Closed in favour of #50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the standalone Feature Extractor tool with feature extraction built directly into the Perform screen's Adjust Input widget. Extraction is now zero config (fbpca, 8 features, deterministic seeding) and runs in a background process while rendering continues. Results are stored per model under the app data folder, keyed by model content hash, and load automatically whenever that model is opened. The old workflow (pick model, choose folder, extract, reopen model in Perform, browse, load) collapses to a single Extract features click per model.
The GANSpace logic moves from
ganspace/into a new testedfeatures/package (estimators, extraction core, store, worker), covered by the test suite and a new CI workflow.Highlights:
Type of change
How was this tested?
Automated: 52 tests pass (
uv run pytest) covering estimator contracts, extraction determinism, sign stabilization, clamping, cancellation, conditional models, RNG state restoration, store roundtrip and hash collision handling, worker job protocol, and preset state validation. A new GitHub Actions workflow runs the suite on push and PR.Manual (macOS, MPS): extraction end to end on a conditional 1024px model from Perform, background progress with live rendering, auto load on model reopen, Re-extract, per slider Randomize and Reset with feature/random labels, header layout.
Still needs manual verification:
Checklist
<type>: <subject>)docs/orREADME.mdis updated if user-visible behavior changedrelease.py(no new runtime files:features/is pure code, bundled automatically)Note: docs screenshots for the Tools and Adjust Input pages still show the old UI and need recapturing.
This PR was developed with the assistance of an AI coding tool.
Generated with AI assistance