Add mcoplib mcoplib build script lint

[ghangz]

Summary

• Adds a focused mcoplib build script lint improvement for MetaX-MACA/mcoplib.
• The change targets MetaX MACA development and validation workflows, with emphasis on earlier diagnostics, reproducible logs, or safer benchmark tooling.
• Existing default behavior is kept compatible; the new logic is scoped to explicit checks, helper tools, or validation metadata.

Validation

• Verified on Gitee.AI MetaX GPU resources: mcoplib_McFlashInfer_TileLang_20260701, mcoplib and McFlashInfer batch 18/18 PASS.
• Branch validation command: python tools/build_script_lint.py --self-test
• Pull request text is intentionally ASCII-only to avoid encoding issues on web forms and API clients.

Review notes

• Source branch: ghangz:mengz/mcoplib-build-script-lint
• Target branch: MetaX-MACA/mcoplib:main
• Maintainers can modify this branch if follow-up adjustments are needed.

[gemini-code-assist]

Code Review

This pull request introduces a new Python script, tools/build_script_lint.py, designed to lint shell scripts for common deployment issues such as CRLF line endings, missing fail-fast mode, and missing required tokens. The reviewer provided valuable feedback to improve the script's robustness: deduplicating matched files by collecting glob results into a set, using regular expressions to check for fail-fast configurations more accurately (avoiding false positives on variations like set -ex), and validating that the target root directory exists to prevent silent failures in CI/CD pipelines.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The current implementation of GLOBS contains both *.sh and **/*.sh. Because **/*.sh matches files in the root directory as well as subdirectories, any .sh files in the root directory will be matched by both patterns. This leads to duplicate processing of the same files and duplicate findings in the final report.

To prevent duplicate processing, we should collect all matched paths into a set before iterating over them.

    paths = set()
    for pattern in GLOBS:
        paths.update(root.glob(pattern))
    for path in sorted(paths):
        if not path.is_file():
            continue
        text = path.read_text(encoding="utf-8", errors="replace")
        rel = path.relative_to(root).as_posix()

[gemini-code-assist]

Import the re module to support robust regular expression matching for the fail-fast check.

Suggested change

	import argparse
	import json
	from pathlib import Path
	import argparse
	import json
	from pathlib import Path
	import re

[gemini-code-assist]

Checking for the literal substring "set -e" will produce false positives (warnings) for shell scripts that enable fail-fast mode using other standard and valid syntax, such as set -ex, set -eu, set -eux, or set -o errexit.

Using a regular expression to match these common fail-fast patterns will make the check much more robust and prevent false warnings.

Suggested change

	if "set -e" not in text and path.suffix in (".sh", ""):
	findings.append({"path": rel, "severity": "warning", "message": "shell script does not enable fail-fast mode"})
	if not re.search(r"set\s+-(?:[a-z]*e[a-z]*|o\s+errexit)\b", text) and path.suffix in (".sh", ""):
	findings.append({"path": rel, "severity": "warning", "message": "shell script does not enable fail-fast mode"})

[gemini-code-assist]

If the directory specified by --root does not exist or is not a directory, pathlib.Path.glob will silently return an empty generator, resulting in 0 findings. This can lead to silent failures in CI/CD pipelines if there is a typo in the path.

Adding validation to ensure the root path exists and is a directory prevents this issue.

Suggested change

	if args.self_test:
	self_test()
	return 0
	print(json.dumps(lint(Path(args.root)), ensure_ascii=False, indent=2))
	return 0
	if args.self_test:
	self_test()
	return 0
	root_path = Path(args.root)
	if not root_path.is_dir():
	parser.error(f"Root path '{args.root}' does not exist or is not a directory.")
	print(json.dumps(lint(root_path), ensure_ascii=False, indent=2))
	return 0