feat: dark mode#192
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the dark theme color palette in Color.kt and enables dark theme support by default in FoliaryTheme using isSystemInDarkTheme(). Feedback highlights that enabling dark theme exposes an inverted status bar style bug in Theme.ios.kt, where UIStatusBarStyleDarkContent and UIStatusBarStyleLightContent are swapped, and suggests correcting this mapping.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @Composable | ||
| fun FoliaryTheme( | ||
| isDarkTheme: Boolean = false, // isSystemInDarkTheme(), Dark mode will be enabled later | ||
| isDarkTheme: Boolean = isSystemInDarkTheme(), |
There was a problem hiding this comment.
Enabling dark theme here will expose an inverted status bar style bug in Theme.ios.kt.
Currently, Theme.ios.kt implements SetupPlatformStatusBar as:
UIApplication.sharedApplication.setStatusBarStyle(
if (isDarkTheme) UIStatusBarStyleDarkContent else UIStatusBarStyleLightContent
)However:
UIStatusBarStyleDarkContentrenders dark status bar content (intended for light backgrounds).UIStatusBarStyleLightContentrenders light status bar content (intended for dark backgrounds).
This means the current iOS implementation is inverted, resulting in invisible status bar icons in both light and dark modes. Please update Theme.ios.kt to correct this:
UIApplication.sharedApplication.setStatusBarStyle(
if (isDarkTheme) UIStatusBarStyleLightContent else UIStatusBarStyleDarkContent
)
Description
Type of Change
Checklist