Skip to content

feat: dark mode#192

Merged
MessiasLima merged 2 commits into
mainfrom
79-revise-dark-mode-color-scheme-with-lighter-dark-tones
Jul 21, 2026
Merged

feat: dark mode#192
MessiasLima merged 2 commits into
mainfrom
79-revise-dark-mode-color-scheme-with-lighter-dark-tones

Conversation

@MessiasLima

@MessiasLima MessiasLima commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Description

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation update
  • Chore / CI

Checklist

  • I have followed the project's coding conventions
  • I have added tests for my changes
  • All tests pass locally
  • I have updated the documentation where applicable

@MessiasLima MessiasLima linked an issue Jul 21, 2026 that may be closed by this pull request
4 tasks

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dark theme color palette in Color.kt and enables dark theme support by default in FoliaryTheme using isSystemInDarkTheme(). Feedback highlights that enabling dark theme exposes an inverted status bar style bug in Theme.ios.kt, where UIStatusBarStyleDarkContent and UIStatusBarStyleLightContent are swapped, and suggests correcting this mapping.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Composable
fun FoliaryTheme(
isDarkTheme: Boolean = false, // isSystemInDarkTheme(), Dark mode will be enabled later
isDarkTheme: Boolean = isSystemInDarkTheme(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Enabling dark theme here will expose an inverted status bar style bug in Theme.ios.kt.

Currently, Theme.ios.kt implements SetupPlatformStatusBar as:

UIApplication.sharedApplication.setStatusBarStyle(
    if (isDarkTheme) UIStatusBarStyleDarkContent else UIStatusBarStyleLightContent
)

However:

  • UIStatusBarStyleDarkContent renders dark status bar content (intended for light backgrounds).
  • UIStatusBarStyleLightContent renders light status bar content (intended for dark backgrounds).

This means the current iOS implementation is inverted, resulting in invisible status bar icons in both light and dark modes. Please update Theme.ios.kt to correct this:

UIApplication.sharedApplication.setStatusBarStyle(
    if (isDarkTheme) UIStatusBarStyleLightContent else UIStatusBarStyleDarkContent
)

@MessiasLima
MessiasLima merged commit 4fc6b29 into main Jul 21, 2026
2 checks passed
@MessiasLima
MessiasLima deleted the 79-revise-dark-mode-color-scheme-with-lighter-dark-tones branch July 21, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise dark mode color scheme with lighter dark tones

1 participant