Skip to content

feat: task data layer#191

Merged
MessiasLima merged 10 commits into
mainfrom
120-task-domain-model-and-data-layer
Jul 21, 2026
Merged

feat: task data layer#191
MessiasLima merged 10 commits into
mainfrom
120-task-domain-model-and-data-layer

Conversation

@MessiasLima

@MessiasLima MessiasLima commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Description

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation update
  • Chore / CI

Checklist

  • I have followed the project's coding conventions
  • I have added tests for my changes
  • All tests pass locally
  • I have updated the documentation where applicable

@MessiasLima MessiasLima linked an issue Jul 21, 2026 that may be closed by this pull request
Task domain model and data layer #120
Closed
11 tasks
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 21, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Task entity, its database schema, and the corresponding repository and DAO layer to support querying today's tasks. The review identified several critical issues that need to be addressed: incorrect imports of Instant and Clock from kotlin.time instead of kotlinx.datetime which will cause compilation failures; a logical bug in the SQL query that retrieves all future tasks instead of filtering specifically for today's 24-hour window; and the use of Long instead of Double for latitude and longitude coordinates, which results in a severe loss of geographical precision.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .../commonMain/kotlin/dev/appoutlet/foliary/core/database/typeconverter/InstantTypeConverter.kt
Comment thread foliary/src/commonMain/kotlin/dev/appoutlet/foliary/data/task/database/TaskDao.kt
Comment thread foliary/src/commonMain/kotlin/dev/appoutlet/foliary/data/task/database/entity/Task.kt
Comment thread foliary/src/commonMain/kotlin/dev/appoutlet/foliary/data/task/TaskRepositoryImpl.kt Outdated
Comment thread foliary/src/commonMain/kotlin/dev/appoutlet/foliary/data/task/database/TaskDao.kt Outdated
Comment thread foliary/src/commonMain/kotlin/dev/appoutlet/foliary/data/task/TaskRepositoryImpl.kt
Comment thread foliary/src/commonMain/kotlin/dev/appoutlet/foliary/data/task/database/entity/Location.kt Outdated
@MessiasLima MessiasLima changed the title chore: task data layer feat: task data layer Jul 21, 2026
@MessiasLima
MessiasLima merged commit 954ea9f into main Jul 21, 2026
1 check passed
@MessiasLima
MessiasLima deleted the 120-task-domain-model-and-data-layer branch July 21, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Task domain model and data layer

1 participant

@MessiasLima