Skip to content

Finalization of 2026.4.0 #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
varmar05 merged 2 commits into from
May 11, 2026
+3 −2
Merged

Finalization of 2026.4.0 #623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ae3658
Fix invalid json error handling
varmar05 May 8, 2026
1b65c10
Merge pull request #622 from MerginMaps/fix_error_handling
MarcelGeo May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions server/mergin/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,9 +389,10 @@ def handle_exception(e):
def log_bad_request(response):
"""Log bad requests for easier debugging"""
if response.status_code == 400:
if response.json.get("detail"):
json_body = response.get_json(silent=True)
if json_body and json_body.get("detail"):
# default response from connexion (check against swagger.yaml)
logging.warning(f'HTTP 400: {response.json["detail"]}')
logging.warning(f'HTTP 400: {json_body["detail"]}')
else:
# either WTF form validation error or custom validation with abort(400)
logging.warning(f"HTTP 400: {response.data}")
Expand Down
Loading