Skip to content

Fix network provider issues#4535

Open
Withalion wants to merge 7 commits into
masterfrom
fix/network-provider
Open

Fix network provider issues#4535
Withalion wants to merge 7 commits into
masterfrom
fix/network-provider

Conversation

@Withalion

Copy link
Copy Markdown
Contributor

Fixes issues outlined in this comment

Points 4 & 5 have been recorded in it's own issue.

@Withalion Withalion added this to the 2026.3.0 milestone Jun 11, 2026
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27704714269

Warning

No base build found for commit 1905517 on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 57.301%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15403
Covered Lines: 8826
Line Coverage: 57.3%
Coverage Strength: 97.69 hits per line

💛 - Coveralls

@IvaKuklica

Copy link
Copy Markdown

External GPS Re-testing:

Application:
Device/OS: 🤖 Samsung Galaxy A53 / Android 15
App: Mergin Maps: 2026.3.0 - 822451

Summary:

🟢 1. Inconsistent receiver identity between GPS receiver list and GPS info panel - test passed
🟢 2. Mismatch between acceptance criteria and displayed device name - test passed
🔴 3. Frozen GPS data after offline mode and return back to online mode - No error notification on connection loss - the issue still persists
🟠 4 and 5. Connection flow and misleading green circle - enhancement created ---> #4536
🟢 6. Duplicate "External receivers" sections displayed on screen - test passed
🟢 7. Misleading error message and missing error icon on failed network connection - test passed

NOTE for @Withalion : external GPS for iOS hasn't been tested yet. I will continue working on it and complete the testing in a future update.

@Withalion

Copy link
Copy Markdown
Contributor Author

Regarding point 3 I'm aware there is no notification, but the app should say the connection was lost after some time and it should reconnect when the device gets online. Does this happen?

@IvaKuklica

IvaKuklica commented Jun 12, 2026

Copy link
Copy Markdown

Hi @Withalion

🔴 3. Frozen GPS data after offline mode and return back to online mode - No error notification on connection loss - the issue still persists. Please, see description of application's behaviour during Offline (Airplane mode) and return back to Online

Behaviour During Offline Mode
When the device loses internet connectivity, the application does not correctly reflect the loss of connection to the external GPS receiver. The following behaviour was observed:

  • The external GPS receiver status remains displayed as "Connected" — no connection loss is indicated to the user
  • The GPS info panel displays frozen data from the last known position — no live updates are shown
  • No error or warning message is shown to inform the user that the data connection has been lost

Behaviour After Returning to Online Mode
When the device regains internet connectivity, the application does not automatically restore the GPS receiver connection.

  • GPS data remains frozen — the connection to the external receiver is not automatically re-established
  • No notification or prompt is displayed to inform the user that reconnection is required

The only way to restore the connection is to manually switch to a different GPS receiver and switch back to the original one — there is no automatic recovery or reconnect button available

Screenrecord:

Screen_Recording_20260612_101238.mp4

@Withalion

Copy link
Copy Markdown
Contributor Author

thanks @IvaKuklica I'll give it another try when I get access to the actual external GNSS device

@IvaKuklica

Copy link
Copy Markdown

External GPS Re-testing

Application:
Device/OS: 🍎 IPhone 15 / iOS 26.5
App: Mergin Maps: 2026.3.0 - 916611

Issues:

1. Incorrect keyboard type displayed for IP address input field - When adding a new network receiver, the IP address input field displays an alphabetical keyboard instead of a numeric keyboard. Since IP addresses consist of numbers and dots only, the correct keyboard type for this field should be numeric.
Screenshot 2026-06-15 135620

Enhancement - UX/UI

1. No pop-up warning displayed when connection to external receiver fails - When a connection to an external network receiver fails, the app does not display any pop-up warning or error notification to the user.

@Withalion Withalion linked an issue Jun 17, 2026 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 69431 dmg Expires: 15/09/2026 #6943
linux Build 📬 Mergin Maps 69691 x86_64 Expires: 15/09/2026 #6969
win64 Build Build failed or not found. #6141
Android Build 📬 Mergin Maps 825351 APK [arm64-v8a] Expires: 15/09/2026 #8253
📬 Mergin Maps 825351 APK [arm64-v8a] Google Play Store #8253
Android Build 📬 Mergin Maps 825311 APK [armeabi-v7a] Expires: 15/09/2026 #8253
📬 Mergin Maps 825311 APK [armeabi-v7a] Google Play Store #8253
iOS Build 📬 Build number: 26.06.919511 #9195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for network position provider

2 participants