Add elm-review#43
Merged
Merged
Conversation
Author
|
Feel free to cherry-pick the commit applying the fixes while we decide which rules to enable |
Owner
Hi @miniBill thanks for this. I have no problem with this set of rules. I'm happy to merge as-is. Please enable running elm-review in actions though. |
miniBill
force-pushed
the
add-elm-review
branch
from
d57e483 to
31192c4
Compare
…r generates code which doesn't pass validation
Author
|
Added to CI |
Merged
Author
|
poke |
MaybeJustJames
added a commit
that referenced
this pull request
Dec 8, 2025
Fix the elm-review errors that were suppressed in #43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Add elm-review with a mostly standard config. Fix small issues reported, add suppressions for the others.
This is marked as draft because which rules to enable is a discussion to be had.
Checklist: