fix: treat set-but-empty RIDDLE_OPENAI_REASONING as unset#14
Open
vnnkl wants to merge 1 commit into
Open
Conversation
Config UIs that write env files (remagic's settings form has a "" option in its reasoning select) produce RIDDLE_OPENAI_REASONING= — set but empty. The code then sends "reasoning_effort":"", which OpenAI rejects with 400 'Unrecognized request argument supplied: reasoning_effort' on non-reasoning models, silently killing every turn. Trim and treat empty as unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the closed #8, reduced to the one piece v0.3.0 didn't fix.
remagic config riddle(and any env-file-writing config UI whose select includes the""option — as settings.schema.json does) writesRIDDLE_OPENAI_REASONING=— set but empty.std::env::var(...).ok()then yieldsSome(""), and the request carries"reasoning_effort":"", which OpenAI rejects with:…on every turn, with nothing visible on the page. Hit this in the wild on a Paper Pro configured through remagic (journal evidence in #7/#8).
One-line-ish fix: trim and filter empty, so present-but-blank behaves like absent.
🤖 Generated with Claude Code