[PATCH] Fix raw SQLite template parameter dropping for distinct_id column#14
Open
GableTheSnail wants to merge 1 commit into
Open
[PATCH] Fix raw SQLite template parameter dropping for distinct_id column#14GableTheSnail wants to merge 1 commit into
GableTheSnail wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! It was a tough day figuring out why the "Distinct Id" is not filled in but all other parameters, including geo-parameters such as the Country, Region or City are filled-in more than often. I narrowed it down to an issue in translating from PostgreSql with one field being improperly named.
I fixed it in the meanwhile using a database trigger, which is very elegant to work around the issue:
because it only needs to be set once. After that the "Distinct Id" field started to be populated, which was great.
The patch adds a file under the patches directory to rename the parameter properly so it should work directly without any changes unless I am missing something.
Many thanks for the SQLite port, it's very lightweight and works great for me/us!
Cheers!