chore: add review rubric + PR template (governance) - #118
Merged
Conversation
A fixed, repeatable review checklist (.github/REVIEW.md) and a PR template (.github/PULL_REQUEST_TEMPLATE.md), so reviews score named dimensions (correctness / reuse / API / naming / generality + adoption-specific fidelity / layer / axiom-clean / #112 exposure) instead of ad-hoc judgment. Machine gates stay in CI; the rubric covers what CI can't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two governance docs under
.github/(no change to the Lean library):.github/REVIEW.md— a fixed reviewer checklist. Splits machine gates (CI: build / no-sorry / linters / shake — don't re-check) from human dimensions (correctness, reuse, API, naming, generality), plus an adoption-PR section (faithful port, correct layer, axiom-clean, Review Issues — OpenGA Hopf–Rinow Formalization #112 exposure)..github/PULL_REQUEST_TEMPLATE.md— author self-check mirroring the rubric.Goal: reviews pass a repeatable checklist rather than ad-hoc judgment (borrowed from the TauCeti review model). Roles and the milestone are linked in REVIEW.md.