Raise the Hopf-Rinow development to Mathlib quality gates - #109
Merged
AxelDlv00 merged 4 commits intoJul 18, 2026
Merged
Conversation
|
@Spring-1211 is attempting to deploy a commit to the xinze-li-bryan's projects Team on Vercel. A member of the Team first needs to authorize it. |
AxelDlv00
reviewed
Jul 18, 2026
AxelDlv00
left a comment
Collaborator
There was a problem hiding this comment.
Nice cleanup — CI is green, no math changes, and the engineering wins are clear: axiom guards on the five facade theorems, tighter section hypotheses instead of a blanket unusedSectionVars suppression, most maxHeartbeats overrides gone, and IsGeodesicallyCompleteAt as a clean reusable one-point predicate. The failing Vercel check is unrelated to this PR (no Vercel step in the added workflow) and shouldn't block anything. LGTM.
AxelDlv00
marked this pull request as ready for review
July 18, 2026 05:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsGeodesicallyCompleteAtas the reusable one-point predicate and document the facade's actual connectedness requirementsMotivation and impact
The branch was already
sorry-free, but several engineering properties were not continuously checked and broad section assumptions obscured theorem generality. This PR makes those properties reproducible and brings the development closer to Mathlib's declaration, style, API, and CI expectations without changing the mathematical Hopf--Rinow conclusions.The abstract ODE layer intentionally retains
CompleteSpace Ein its three Banach-space modules. The finite-dimensional Riemannian layer now relies on the instance supplied byFiniteDimensional ℝ E. Support for the zero-dimensional case is deliberately left for a separate mathematical generalization.Validation
lake build— 3005 jobs completed successfullylake test— exact axiom guards passedlake lint— declaration linting passed forOpenGALiblake exe lint-style OpenGALib— no diagnosticsgit diff --check upstream/feat/hopf-rinow...HEAD— no diagnosticsStatic review also finds no
sorry,admit, orunsafetoken in the Lean sources and no remainingunusedSectionVarsorunusedVariableslinter suppression.