Skip to content

timely-util: fix settle carry threshold test #38073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
def- merged 1 commit into from
Aug 12, 2026
Merged

timely-util: fix settle carry threshold test #38073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/timely-util/src/columnar/chunk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1632,9 +1632,10 @@ mod tests {
#[mz_ore::test]
#[cfg_attr(miri, ignore)] // too slow
fn settle_carry_commits_at_target() {
// ~1.5 MiB per chunk: inside the dead zone of the periodic window
// check (see `at_commit_size`).
let chunk_rows = u64::cast_from(1_500_000usize / 24);
// ~1.5 MiB per chunk (a row serializes to 32 bytes): under
// `at_commit_size`, so the carry has to coalesce, and a coalesced
// pair lands in the dead zone of the periodic window check.
let chunk_rows = u64::cast_from(1_500_000usize / 32);
let mut input: VecDeque<TestChunk> = (0..4u64)
.map(|c| {
let data: Vec<Tuple> = (0..chunk_rows)
Expand All @@ -1645,6 +1646,9 @@ mod tests {
.collect();
let mut out = VecDeque::new();
TestChunk::settle(&mut input, true, &mut out);
// Catches the fixture drifting above `at_commit_size`, where settle
// commits each chunk as-is and the size cap below holds vacuously.
assert!(out.len() < 4, "nothing coalesced");
for chunk in &out {
let col = chunk.clone().into_column();
assert!(
Expand Down
Loading