Develop #91
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "firestore": { | ||
| "rules": "firestore.rules" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import "dotenv/config"; | ||
| import * as admin from "firebase-admin"; | ||
|
|
||
| const serviceAccount = JSON.parse(process.env.FIREBASE_SERVICE_ACCOUNT!); | ||
| const dbId = process.env.VITE_FIREBASE_FIRESTORE_DATABASE_ID!; | ||
|
|
||
| admin.initializeApp({ | ||
| credential: admin.credential.cert(serviceAccount), | ||
| }); | ||
|
Comment on lines
+4
to
+9
There was a problem hiding this comment. 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win Guard env parsing and app init inside the A missing or malformed 🤖 Prompt for AI Agents |
||
|
|
||
| async function run() { | ||
| const securityRules = admin.securityRules(); | ||
|
Comment on lines
+11
to
+12
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🌐 Web query:
💡 Result: Yes, firebase-admin 14.1.0 provides a top-level securityRules API that allows you to access the SecurityRules service for managing and retrieving Firestore security rules [1][2][3]. You can access this service by calling admin.securityRules [2][3]. Once you have the SecurityRules instance, you can use the getFirestoreRuleset method to retrieve the ruleset currently applied to Cloud Firestore [4][5][6]. Example usage: const admin = require('firebase-admin'); admin.initializeApp; // Retrieve the currently applied Firestore ruleset admin.securityRules.getFirestoreRuleset.then((ruleset) => { console.log('Current Firestore ruleset:', ruleset); }).catch((error) => { console.error('Error retrieving ruleset:', error); }); This API was originally introduced in earlier versions of the SDK [1][7] and remains available in version 14.1.0 [8][9]. Citations:
🏁 Script executed: #!/bin/bash
set -euo pipefail
# Locate and inspect the target file.
git ls-files | rg '^get-rules\.ts$|/get-rules\.ts$|^.*get-rules\.ts$' || true
if [ -f get-rules.ts ]; then
wc -l get-rules.ts
cat -n get-rules.ts
fi
# Check the firebase-admin version declared in package files, if present.
rg -n '"firebase-admin"|firebase-admin' package.json package-lock.json pnpm-lock.yaml yarn.lock --no-heading || true
# Look for other uses of securityRules in the repo.
rg -n 'securityRules\(' . --no-heading || trueRepository: MatchDock/match-tech Length of output: 2302 🌐 Web query:
💡 Result: In the Firebase Admin SDK, Citations:
Call a ruleset method on the returned service 🧰 Tools🪛 ESLint[error] 12-12: 'securityRules' is assigned a value but never used. ( 🤖 Prompt for AI Agents |
||
| try { | ||
| // The Rules API handles generic rules, let's try to get Firestore rules | ||
| // Using the REST API directly is easier since the SDK might not expose getRules for specific DBs easily. | ||
| console.log("Database ID from env:", dbId); | ||
| } catch(e) { | ||
| console.error(e); | ||
| } | ||
| } | ||
|
|
||
| run(); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Validate the contents of
extraTagsByCategory, not just that it is a map.The PR contract here is category → list of user-created skill names, but this rule accepts any nested structure. Malformed profile data can persist numbers or objects under a category and then break the onboarding code that reads these values as string arrays.
🤖 Prompt for AI Agents