Skip to content

Normalize metadata aliases and TOC section linking#226

Open
jessejhein wants to merge 8 commits into
MartinPacker:mainfrom
jessejhein:pr-format-fixes
Open

Normalize metadata aliases and TOC section linking#226
jessejhein wants to merge 8 commits into
MartinPacker:mainfrom
jessejhein:pr-format-fixes

Conversation

@jessejhein

Copy link
Copy Markdown

I ran a torture test trying to understand the syntax and how the tool worked to evaluate it. (Love it BTW.) I found a couple places I needed to fix things I think. Mostly whitespace issues and casing issues.

  • canonical cardGraphic* option names for card metadata
  • support for additional funnel aliases such as funnellabelsposition and color-name variants
  • support for wholeTableLineStyling = both
  • TOC bullet flattening so nested bullet structures render correctly
  • normalized section-slide keys so TOC links resolve reliably even when titles have surrounding whitespace

Keep sorted numeric list conversion with ProcessingOptions.dynamicallySetOption so dynamic table row and column line metadata can use the same conversion as top-level metadata without duplicating helper code.
Handle the nested bullet-list shape locally inside createTOCSlide so styled TOC slides can render without changing SlideInfo or normal content slide parsing.
Compare card graphic metadata using lower-case keys produced by the parsers and allow dynamic cardGraphicPadding through the existing float conversion path.
Accept documented funnel label-position aliases and parse dynamic funnel colour values through the same colour parser used by top-level metadata while preserving dynamic reset values.
Treat addTableLines: both as the documented alias for the existing all-cell-edge styling behavior.
Strip section-title keys when storing and resolving TOC hyperlinks so styled TOC links tolerate the whitespace produced by parsed section headings.
Keep lower-case metadata keys as accepted input, but write the touched card and funnel values through their existing camelCase option names. Replace the funnel colour key mapping with direct canonical branches plus a typed helper for shared dynamic colour parsing.
@jessejhein

Copy link
Copy Markdown
Author

I'm not certain on the TOC changes, but I don't think I quite have pictured what you intended. Feel free to tell me that these are meaningless.

@MartinPacker

Copy link
Copy Markdown
Owner

Thank you for this. This is a complex set of changes that I need to examine (and potentially document).

I'm going to have to defer this (and Issue 225 for that matter) until after the next release. I hope to get that done this week - but it's an extremely busy week.

@jessejhein

Copy link
Copy Markdown
Author

Thank you for this. This is a complex set of changes that I need to examine (and potentially document).

I'm going to have to defer this (and Issue 225 for that matter) until after the next release. I hope to get that done this week - but it's an extremely busy week.

No problem. Since most was just touching up things that I expected to work based on the user docs (even if I misunderstood the first time) I think documentation is covered, but if you want me to revise with documents let me know.

@MartinPacker

Copy link
Copy Markdown
Owner

If you're going to work on documentation you will need to use mdpre (with the -v option) and then something like Sublime Text to convert the resulting Markdown to HTML.

Probably best to let me do it.

But I would need to know if there were any external interface changes to take into account - such as new metadata items or relaxation of syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants