TICKET-602: Fix marks_earned marker ignored when earned equals total or zero#716
Merged
david-yz-liu merged 3 commits intomasterfrom Apr 24, 2026
Merged
Conversation
donny-wong
reviewed
Apr 13, 2026
Contributor
donny-wong
left a comment
donny-wong
left a comment
There was a problem hiding this comment.
Thank you @Naragod, looks good! Please add this PR to the changelog.
Contributor
Author
Done. |
This was
linked to
issues
Apr 22, 2026
donny-wong
approved these changes
Apr 22, 2026
Contributor
david-yz-liu
left a comment
david-yz-liu
left a comment
There was a problem hiding this comment.
@Naragod the change is good, please just note my comment about code style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues: