Make action-policy objectives padding-aware - #71
Open
zjn20030811 wants to merge 1 commit into
Open
Conversation
Normalize diffusion and ACT losses over valid action elements and apply consistent visual preprocessing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The diffusion branch received the loader's
[0, 1]images without the feature normalization used by the other policies. Its masked loss then calledmean()over the padded tensor, so two otherwise identical batches with different amounts of padding optimized different effective objectives. The shared masked reduction makes the objective invariant to chunk padding while preserving the standard mean when every timestep is valid.This is separate from the existing open questions about dependency setup and does not duplicate an open pull request. It also resolves the behavior described in #48.
Validation
python -m pytest -q tests/test_losses.py(4 passed)python -m py_compile policy.py losses.pygit diff --check