Add pylint to CI; add PR preview deployments#72
Merged
Conversation
Pylint:
- Configure via pyproject.toml: disable cosmetic/complexity checks,
max-line-length=250, fail-under=9.0 in CI (currently scores 9.48/10)
- Fix real issues in files touched this sprint: bare-except → Exception,
singleton comparisons (== True → truthiness), undefined loop variable,
unused numpy imports in nchart.py and dotplot.py
- Add pylint to [dev] extras and test.yml CI step
PR previews:
- Switch deploy-pages.yml from actions/deploy-pages to
peaceiris/actions-gh-pages with keep_files=true so PR subdirs persist
- New pr-preview.yml: deploys public/ to pr-preview/pr-{N}/ on every
push to a PR touching public/, posts/updates a comment with the URL,
cleans up on PR close
- NOTE: requires one manual settings change — GitHub Settings → Pages →
Source → "Deploy from a branch" → gh-pages / (root)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keeping the simpler GitHub Actions-based Pages deployment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pylint:
pyproject.toml: cosmetic/complexity checks disabled,max-line-length=250, fail-under=9.0 (currently scores 9.48/10)bare-except→Exception,== True→ truthiness, undefined loop variable (queryin uniq_anchor), unused numpy imports innchart.pyanddotplot.pypylintto[dev]extras and CI step intest.yml🤖 Generated with Claude Code