test: pin egui resize-response id coupling - #4
Merged
Conversation
The diff-panel and file-list splitter persistence in App::update reads
an egui-internal resize response keyed `Id::new(<panel>).with("__resize")`.
That id suffix is not part of egui's public API, so an egui upgrade that
renames it would silently break splitter persistence with no compile error.
Add two headless single-pass egui tests that assert the resize response is
readable at the exact ids the prod code depends on, so such a break fails
loudly in CI instead.
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
enabled auto-merge (squash)
June 24, 2026 12:38
selckin
added a commit
to selckin/gitkay
that referenced
this pull request
Jul 18, 2026
dispatch_prefetch warmed selected ± (4 below, 2 above) into the diff cache. Instead, warm every commit currently visible in the list, ordered by distance from the selected row (closest first; ties favor the row below / scroll-down direction), with a hard cap (PREFETCH_MAX=24) so a very tall window doesn't queue a huge number of diff builds. Re-fires when the list scrolls new rows into view as well as when a fresh diff settles; dispatch early-returns if the visible commits are already cached, so scrolling over warm rows is a no-op. prefetch_targets now reads oids straight from the commit list (no whole-list oid clone per dispatch — the earlier review's finding Marenz#4). Pure + unit-tested for distance order, tie-break, cap, view limiting, and virtual-row exclusion. Requested feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff-panel and file-list splitter persistence in
App::updatereads an egui-internal resize response keyedId::new(<panel>).with("__resize")(added in #3). That id suffix is not part of egui's public API, so an egui upgrade that renames it would silently break splitter persistence with no compile error.These two headless single-pass egui tests assert the resize response is readable at the exact ids the production code depends on (
diff_panel.__resize,file_list_panel.__resize), so such a break fails loudly in CI instead of going unnoticed.18 tests pass,
clippy --all-targets -- -D warningsclean.