Week9

[ManuelaFlores]

Hi Fuad or Filip,
Here are my changes for week9

[abunur]

Hi Manuela, great job on the homework for this week. Nice job on code/package organization. Some minor points:

There are some UI issues on the login screen. This type of issue should come up during user testing so not sure why it's there. I could not find any way to dismiss the keyboard when typing the username in the login screen. There should be a next button or a done button, which should be available using the right keyboard settings, to advance to the next screen or dismiss the keyboard. It's not good UX to force the user to dismiss the keyboard by hitting the back button just to get to the next field in the form.

Similarly, on the detail screens, I would suggest having a back button in the UI rather than relying on the hardware back button which might be a variable experience across devices.

You should delete the sample tests / sample test files. There are there as a starting template and example for you, but once you have written your own tests there's no reason to keep them around.

You have some deprecation warnings in your UI test. Beware in general of deprecation warnings - they are usually harder to address, and the earlier you address them the better and easier it usually is. Try to always clean up your code and resolve any warnings prior to code review.

You have version warnings in your Gradle. Consider why you are using outdated library versions, and always upgrade unless you have a strong reason for wanting to use an older one.

I think I would have liked to have see more tests, overall. Your grade for this assignment is "good job"

[ManuelaFlores]

Hi Fuad, thanks for your feedback :). I will ensure to make those changes 👍