Skip to content

Week10#10

Open
ManuelaFlores wants to merge 7 commits into
developfrom
week10
Open

Week10#10
ManuelaFlores wants to merge 7 commits into
developfrom
week10

Conversation

@ManuelaFlores
Copy link
Copy Markdown
Owner

No description provided.

@abunur
Copy link
Copy Markdown

abunur commented Aug 20, 2020

Hi Manuela, great job on this homework. Your grade for this assignment is "above and beyond".

Some quick notes:

UI/UX

"sort alphabetically" option - what's the alternative? I find it confusing to choose between a single sort option and "get all photos". If you are going to offer a sort option, you should offer at least one other option, generally the reverse sort.

What does "get all photos" actually do? Aren't all the photos available from the start? the purpose is not obvious from the UI.

Code

You should delete the sample tests that are generated when you create the project. They serve no purpose once you start adding real tests.

You have added UI tests, which is great, but both of your UI tests fail. You should make sure your PR has passing tests.

Also you might consider using use of whenever from Mockito

Otherwise your test seem fine to me.

Great job on creating a Login Scope

Great job on keeping your code very clean!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants