perf/forms type stability - #415
Open
J15525 wants to merge 5 commits into
Open
Conversation
J15525
added
test 🧪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some tests to check for type stability in forms. There were a few smaller things that could be improved type-stability wise, so I did. I also made one of the bspline helpers more consistent. I don't think the overall speed improved, but it also didn't get worse.
I did not create separate inference tests for the fields, spaces, and algebraic operators, because those are the inputs to the form operator and should thus be covered by JET through those calls.