Adjust logs pertinence#172
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 89.13% 89.29% +0.16%
==========================================
Files 103 104 +1
Lines 2254 2269 +15
Branches 435 436 +1
==========================================
+ Hits 2009 2026 +17
+ Misses 232 230 -2
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
greg0ire
reviewed
May 19, 2026
bb596a5 to
4a4c353
Compare
4a4c353 to
efa1c4a
Compare
greg0ire
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop orphan Review rows when Slack channel is archived
When a Slack channel is archived, every chat.update / chat.postMessage from a review-flow webhook returns is_archived and the Review row keeps pointing at the dead channel — re-triggering the failure (and commit 1's webhook slack work failed log) on every subsequent MR update, note or push. Channels do get archived as a routine cleanup; treat it as an expected operational state rather than a hard error.
Demote expired_trigger_id to structured warn
errorMiddlewarealready replies withEXPIRED_TRIGGER_ID_ERROR_MESSAGEwhen Slack rejects aviews.openwithexpired_trigger_id, but the underlying error was still logged throughlogger.error(error)as a bare stack trace.Demote users_not_found to info and unify email lookup
"Failed to to fetch slack user with emails" was noisy in the logs: it covered the perfectly normal case of a GitLab user who has left the company (or is external, or has no corporate Slack account) and emitted it at error level with no structured context.