fix(slack): truncate slack body message if limit is reached#171
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 89.10% 89.13% +0.02%
==========================================
Files 103 103
Lines 2248 2254 +6
Branches 429 431 +2
==========================================
+ Hits 2003 2009 +6
Misses 232 232
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aa9a985 to
a5f8459
Compare
greg0ire
reviewed
May 12, 2026
97810fb to
fd17171
Compare
08b9087 to
37daf65
Compare
greg0ire
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an attempt to fix this issue:
invalid_blockserrors. There was a bug in the truncation which did not take into account the appended message length properly. The latter resulted in exceeding the Slack limit in some cases.CONFIG.requestBodySizeLimit. This is due to the fact that Gitlab webhook payloads routinely exceed the previous 500kb when MRs carry long descriptions.