Skip to content

fixed ASAN check and increased coverage on RmM-tree - #32

Merged
Malkovsky merged 5 commits into
mainfrom
rmM-tree
Mar 2, 2026
Merged

fixed ASAN check and increased coverage on RmM-tree#32
Malkovsky merged 5 commits into
mainfrom
rmM-tree

Conversation

@RSMT98

@RSMT98 RSMT98 commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@kilo-code-bot

kilo-code-bot Bot commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
include/pixie/rmm_tree.h 273 Cache segment_size_bits (and related arrays) in select10() to reduce repeated bounds checks in a hot loop.
Other Observations (not in diff)

Issues found in unchanged code that cannot receive inline comments:

File Line Issue
None N/A N/A
Files Reviewed (4 files)

Fix these issues in Kilo Cloud

@codecov-commenter

codecov-commenter commented Mar 1, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 92.23301% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.35%. Comparing base (741734b) to head (69b6509).

Files with missing lines Patch % Lines
include/pixie/rmm_tree.h 71.42% 2 Missing and 2 partials ⚠️
src/tests/test_rmm.cpp 95.50% 3 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   82.48%   86.35%   +3.86%     
==========================================
  Files          11       11              
  Lines        2752     2850      +98     
  Branches      545      562      +17     
==========================================
+ Hits         2270     2461     +191     
+ Misses        344      254      -90     
+ Partials      138      135       -3     
Flag Coverage Δ
gcov 86.35% <92.23%> (+3.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RSMT98
RSMT98 requested a review from Malkovsky March 1, 2026 19:59
@RSMT98 RSMT98 changed the title Trying to fix ASAN check fixed ASAN check and increased coverage on RmM-tree Mar 1, 2026
Comment thread include/pixie/rmm_tree.h Outdated
Comment thread .github/workflows/build-test.yml
Comment thread AGENTS.md Outdated
Comment thread src/tests/test_rmm.cpp Outdated
Comment thread .github/workflows/build-test.yml Outdated
Comment thread src/tests/test_rmm.cpp
Comment thread .github/workflows/build-test.yml
Comment thread include/pixie/rmm_tree.h
@RSMT98
RSMT98 requested a review from Malkovsky March 1, 2026 21:11
@Malkovsky
Malkovsky merged commit 59f0fb9 into main Mar 2, 2026
4 checks passed
@Malkovsky
Malkovsky deleted the rmM-tree branch April 5, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants