Skip to content

feat: clickable robot cards with detail modal (fixes #6) - #11

Open
xdnaimino wants to merge 1 commit into
Malek-Ghorbel:mainfrom
xdnaimino:feat/robot-detail-modal
Open

feat: clickable robot cards with detail modal (fixes #6)#11
xdnaimino wants to merge 1 commit into
Malek-Ghorbel:mainfrom
xdnaimino:feat/robot-detail-modal

Conversation

@xdnaimino

Copy link
Copy Markdown
Contributor

Summary

  • Add RobotModal component with dialog role, aria-modal, close on Escape/backdrop click
  • Update Card with role=button, tabIndex, aria-label, keyboard support (Enter/Space)
  • Update CardList to pass onSelect callback to each Card
  • Add App state management for selected robot and modal visibility

Evidence

  • All 20 tests passing (Card.test.js, RobotModal.test.js, SearchBox.test.js)
  • No new dependencies added

Checklist

  • RobotModal renders robot details (name, email, ID, avatar)
  • Modal has correct dialog attributes (role=dialog, aria-modal=true)
  • Close button has aria-label
  • Escape key closes modal
  • Backdrop click closes modal
  • Content click does NOT close modal
  • Card has role=button, tabIndex=0, aria-label
  • Card responds to click, Enter, and Space
  • All existing tests pass

- Add RobotModal component with dialog role, aria-modal, close on Escape/backdrop
- Update Card with role=button, tabIndex, aria-label, keyboard support
- Update CardList to pass onSelect callback
- Add App state management for selected robot and modal
- All 20 tests passing

Fixes Malek-Ghorbel#6
@syntaro-bot

syntaro-bot Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

🔄 Syntaro quality gate: waiting for CI checks to pass before marking this PR ready to merge…

@syntaro-bot
syntaro-bot Bot requested a review from Malek-Ghorbel August 22, 2026 13:52
@syntaro-bot

syntaro-bot Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

🔄 Syntaro requested review from: @Malek-Ghorbel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant