feat: clickable robot cards with detail modal - #10
Open
xdnaimino wants to merge 2 commits into
Open
Conversation
Contributor
|
🔄 Syntaro quality gate: waiting for CI checks to pass before marking this PR ready to merge… |
Contributor
|
🔄 Syntaro requested review from: @Malek-Ghorbel |
xdnaimino
force-pushed
the
Malek-Ghorbel_first-react_6
branch
from
August 21, 2026 23:09
f5ed899 to
f64607e
Compare
added 2 commits
August 22, 2026 15:43
…k-Ghorbel#6) - Add onSelect prop to Card with role=button, tabIndex, keyboard handlers, pointer cursor - Fix robohash URL from ?50x50 to ?size=200x200 - Thread onSelect through CardList - Add selectedRobot state and modal handlers to App - Create RobotModal with focus trap, Esc/backdrop/close button, scroll lock, aria-modal
xdnaimino
force-pushed
the
Malek-Ghorbel_first-react_6
branch
from
August 22, 2026 15:52
a6bd42b to
1478342
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
Changes
onSelectprop withrole=button,tabIndex=0, keyboard handlers (Enter/Space),pointercursor,aria-label. Fix robohash URL from?50x50to?size=200x200onSelectcallback to each CardselectedRobotstate,onSelectRobot/onCloseModalmethods, passonSelectto CardList, render RobotModal when selectedaria-modal,role=dialog, body scroll lockAcceptance Criteria
Evidence